Skip to content

feat: add dns_cache_timeout for option CURLRequest #9553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 15, 2025
Merged

feat: add dns_cache_timeout for option CURLRequest #9553

merged 13 commits into from
May 15, 2025

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented May 13, 2025

Description
Options for change default DNS Cache Timeout cURL.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr requested review from michalsn and paulbalandan and removed request for michalsn May 13, 2025 15:24
@ddevsr ddevsr added enhancement PRs that improve existing functionalities 4.7 labels May 13, 2025
michalsn
michalsn approved these changes May 14, 2025
View reviewed changes
@paulbalandan paulbalandan changed the title feat: added dns_cache_timeout for option CURLRequest feat: add dns_cache_timeout for option CURLRequest May 14, 2025
paulbalandan
paulbalandan reviewed May 14, 2025
View reviewed changes
@ddevsr ddevsr force-pushed the dns-cache-time-curl branch from 5f71d8f to c3f2f21 Compare May 15, 2025 03:15
@ddevsr ddevsr force-pushed the dns-cache-time-curl branch from 369a47b to a48bc8a Compare May 15, 2025 03:47
@ddevsr ddevsr requested a review from paulbalandan May 15, 2025 04:05
paulbalandan
paulbalandan reviewed May 15, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! Just a minor comment in the doc.

@ddevsr ddevsr requested a review from paulbalandan May 15, 2025 05:00
paulbalandan
paulbalandan reviewed May 15, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final touches, and the rest LGTM.

ddevsr and others added 3 commits May 16, 2025 00:39
@ddevsr @paulbalandan
Update tests/system/HTTP/CURLRequestTest.php
5094584 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@ddevsr @paulbalandan
Update tests/system/HTTP/CURLRequestTest.php
e3a7be0 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@ddevsr @paulbalandan
Update user_guide_src/source/libraries/curlrequest.rst
ad84b38 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@paulbalandan paulbalandan requested a review from michalsn May 15, 2025 17:44
@michalsn michalsn merged commit f7d6142 into codeigniter4:4.7 May 15, 2025
50 checks passed
@michalsn
Copy link
Member

Thank you @ddevsr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

4.7 enhancement PRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr @michalsn @paulbalandan